wboayue / rust-ibapi / 25267123189

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix: surface TWS errors on subscription channels (closes #434) (#490)

* fix: surface TWS errors on subscription channels (closes #434)

Audit StreamDecoders for IncomingMessages::Error handling. When TWS
returns an error tied to a subscription's request_id, decoders that
didn't match on the message type either reproduced the original
"invalid digit found in string" parse failure (PnL, PnLSingle,
WshEventData, ScannerData), terminated with Error::Simple
("unexpected message: Error") losing the IB code/text (option
computations, account summary/position/update variants), or silently
skipped via UnexpectedResponse (option chain, news, wsh metadata,
display groups). 15 decoders now return Err(Error::Message(code, msg))
for type-4 messages.

Also: regression test for realtime_bars Error handling (sync + async)
locks down the prior fix (e1333df3). Sync Subscription log line
distinguishes TWS errors (warn!) from real decode failures (error!).

* test: extract assert_tws_error_message helper

Replace 15 copies of the Error::Message match-and-panic pattern with a
shared helper in common::test_utils. Tightens the new decoder tests
without changing semantics.

Coverage Stats

95 of 105 new or added lines in 8 files covered. (90.48%)

5 existing lines in 3 files now uncovered.

17124 of 19325 relevant lines covered (88.61%)

24.67 hits per line