wboayue / rust-ibapi / 25264080377

92%

push

github

refactor(historical): use Subscription<HistoricalBarUpdate> (closes #431) (#488)

* refactor(historical): replace HistoricalDataStreamingSubscription with generic Subscription

Custom struct duplicated cancel-on-drop, AtomicBool dedup, message_bus
storage, tokio::spawn in async Drop, and inline message dispatch — all
already provided by the generic Subscription<T>. Replaced with a 30-line
StreamDecoder impl (mirrors MarketDepths / Bar / Trade pattern) and a
3-line factory body. Net -271 lines.

Async API breaks: next() now returns Option<Result<HistoricalBarUpdate,
Error>> and there is no separate error() accessor. Sync API unchanged
in this PR; see #487 for the follow-up.

Drop tests rewired to drive through the public factory rather than the
deleted internal constructor, so they exercise the real cancel-on-drop
path end-to-end.

Closes #431.

* comment: collapse keepUpToDate constraint to inline

* simplify: shorten Subscription import path; drop narration comments

20 of 24 new or added lines in 3 files covered. (83.33%)

17037 of 19231 relevant lines covered (88.59%)

24.62 hits per line