Tatsh / wiswa / 25267017780

100%

push

github

utils.postprocess: percent-encode space in KDE Plasma badge label

The third element of the `kde` entry in `_social_badges` is the
shields.io label, which `_simple_icons_badge` interpolates verbatim
into the badge URL as
`https://img.shields.io/badge/{label}-{color}?logo={logo}`. With a
literal space, the resulting Markdown image
`[![KDE Plasma](https://img.shields.io/badge/KDE Plasma-blue?logo=kdeplasma)](https://kde.org/)`
breaks at the space inside the URL and the badge does not render in
generated READMEs that include the `kde` keyword.

Encode the space as `%20`, matching how other multi-word labels in
the same file are spelt (for example
`Buy%20Me%20a%20Coffee-{username}`). The first and third tuple
elements still read `KDE Plasma` because the first is the Markdown
link's anchor text and the third (now `KDE%20Plasma`) is only the
URL path segment.

Strengthen `test_post_process_steps_social_badges` with assertions
that pin both directions of the fix: `KDE%20Plasma-blue` must appear
in the rendered README, and the unencoded `KDE Plasma-blue` must not.
The test already exercised the `kde` branch via its keywords list, so
no new test or fixture was needed.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

478 of 478 branches covered (100.0%)

Branch coverage included in aggregate %.

2476 of 2476 relevant lines covered (100.0%)

5.0 hits per line