dangernoodle-io / breadboard / 25263655219

100%

push

github

fix(bb_mdns): inline scalar string fields in peer / query result (B1-86) (#177)

bb_mdns_peer_t and bb_mdns_query_result_t exposed instance_name,
hostname, and ip4 as `const char *` pointing into a recyclable file-
scope event-pool slot. The header documented the callback-only
lifetime, but the API still made it trivial to retain a pointer past
the callback and read garbage once the slot was reused.

Inline the three scalar strings as fixed-size char arrays sized to
match the underlying event-pool buffers (BB_MDNS_INSTANCE_NAME_MAX=64,
BB_MDNS_HOSTNAME_MAX=64, BB_MDNS_IP4_MAX=16). A struct copy now
preserves the strings; empty fields are zero-length, never NULL.

The variable-length `txt` array stays as a callback-scoped pointer
view — inlining a TXT array would balloon the struct for the typical
4-6-record case. Doc comments updated to call out the split lifetime
contract: scalars are copy-safe, txt requires explicit copy.

One known consumer (TaipanMiner components/knot/src/knot.c) needs
matching NULL-guard cleanup; tracked as TA-348. Smoke envs (esp32,
esp32c3, tdongle, elecrow-p4-hmi7) build clean against this change.

336 of 336 branches covered (100.0%)

Branch coverage included in aggregate %.

557 of 557 relevant lines covered (100.0%)

477.93 hits per line