KarpelesLab / libwallet / 25254395072

24%

Build Type

push

github

Committed by MagicalTux

Commit Message

wltacct/FindAccount: fall back to current-network derived address

Asset:list / Account:fetch return an account JSON whose Address
field is the in-memory result of UpdateAddressForNetwork — for a
secp256k1 account on litecoin that's "ltc1...", "L...", or
"M...". The Dart frontend stashes that address and passes it
back as `from` in subsequent calls (Transaction:maxSendable,
Swap:maxSpendable, …). The DB Address column, though, still holds
the account's *creation-time* address (typically the ETH form),
because UpdateAddressForNetwork mutates only in memory and the
non-Solana paths never persist the change.

Result: psql.Get(Address="ltc1...") finds nothing →
FindAccount returns bare fs.ErrNotExist → router maps to HTTP
404 "file does not exist". Reproduces on every Bitcoin-family
chain when the frontend uses the displayed address as `from`.

Fix: after the direct address lookup misses, walk every account,
derive its address for the current network, and match. Bounded
by accounts-per-wallet (small N) and only fires on the slow path
(DB miss). Same path is used for ed25519 / view accounts via the
existing UpdateAddressForNetwork branches, so the behaviour is
uniform across chain families.

Also: wrap the final fs.ErrNotExist with the missing id so future
404s carry the address that wasn't found instead of a bare "file
does not exist".

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 20 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

3073 of 14915 relevant lines covered (20.6%)

126.77 hits per line