Freegle / Iznik / 9385

70%

Build Type

push

circleci

Committed by invalid-email-address

Commit Message

fix(ban): JoinAndPost was checking the wrong column for bans

handleJoinAndPost looked for memberships.collection='Banned' to detect
banned users, but that value is never written anywhere — V1 and V2 both
ban by deleting the memberships row and inserting into users_banned.
The check was therefore a permanent no-op and banned users could
self-rejoin and post via the Platform's compose-then-submit flow.

13 banned users had bypassed the check in production (cleaned up
separately by deleting the post-ban memberships rows). Test was also
asserting against the bogus state — rewritten to match real ban
representation and to also assert no membership/messages_groups row is
created on a 403.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

13627 of 20587 branches covered (66.19%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

98305 of 134207 relevant lines covered (73.25%)

22.56 hits per line