ruby-grape / grape / 25224938021

97%

master: 97%

Build Type

Pull #2696

github

Committed by ericproulx

Commit Message

Reduce per-request allocations on the request hot path

A bundle of small, behavior-preserving cleanups that drop allocations
or chain walks from every request. Stable values (filter buckets,
versioner options, etc.) are computed once at compile/init and read via
`attr_reader`, instead of being re-resolved through nested hash lookups
on every request.

* `Endpoint#run`: precompute filter buckets (befores, before_validations,
  after_validations, afters, finallies) and `:build_params_with` once
  in `compile!`; replace the dynamic `define_method` accessor block
  with `attr_reader`; remove a dead `header 'Allow', header['Allow']`
  self-assignment.

* `Versioner::Base`: replace the two `define_method`-per-key blocks
  (top-level and `version_options` keys) with `attr_reader` plus ivars
  precomputed in `initialize`. Per-request `pattern`/`prefix`/`vendor`/
  `strict`/etc. lookups now hit attr loads. `DEFAULT_OPTIONS`,
  `attr_reader` list, and ivar assignments alphabetized; redundant
  `version_options` reader dropped.

* `Middleware::Error` / `Middleware::Formatter`: same `options[...]`
  -> `attr_reader` migration. All option keys live in `DEFAULT_OPTIONS`
  (alphabetized), assigned to ivars in `initialize`, read via attr at
  request time. Drop the dead `rescue_subclasses` middleware key (the
  per-handler `:rescue_options` hash carries it, not the middleware
  options).

* `Middleware::Base`: freeze `@options` after `merge_default_options` --
  immutable once initialized. One spec adjusted to construct a fresh
  middleware instead of mutating `subject.options[...]`.

* `ErrorFormatter::Base.call`: third argument is now the
  `rescue_options` hash directly (not the wrapping middleware options).
  Top-level `:backtrace` / `:original_exception` reads instead of
  `dig(:rescue_options, ...)`.

* `Request#make_params`: skip the `except(:version, :route_info)` hash
  allocation in the common case where routing args contain only the
  known keys.

* `Vali... (continued)

Pull Request Pull Request #2696: Reduce per-request allocations on the request hot path

Coverage Stats

1077 of 1161 branches covered (92.76%)

Branch coverage included in aggregate %.

79 of 79 new or added lines in 11 files covered. (100.0%)

1 existing line in 1 file now uncovered.

3378 of 3432 relevant lines covered (98.43%)

32461.97 hits per line