ruby-grape / grape / 25213900833

97%

master: 97%

Build Type

Pull #2696

github

Committed by ericproulx

Commit Message

Reduce per-request allocations on the request hot path

A bundle of small, behavior-preserving cleanups that drop allocations
or chain walks from every request. Stable values (filter buckets,
versioner options, etc.) are computed once at compile/init and read via
`attr_reader`, instead of being re-resolved through nested hash lookups
on every request.

* `Endpoint#run`: precompute filter buckets (befores, before_validations,
  after_validations, afters, finallies) and `:build_params_with` once
  in `compile!`; replace the dynamic `define_method` accessor block
  with `attr_reader`; remove a dead `header 'Allow', header['Allow']`
  self-assignment.

* `Versioner::Base`: replace the two `define_method`-per-key blocks
  (top-level and `version_options` keys) with `attr_reader` plus ivars
  precomputed in `initialize`. Per-request `pattern`/`prefix`/`vendor`/
  `strict`/etc. lookups now hit attr loads.

* `Request#make_params`: skip the `except(:version, :route_info)` hash
  allocation in the common case where routing args contain only the
  known keys.

* `Validators::Base#validate!`: lazy-allocate `array_errors`. Saves one
  Array allocation per validator per request when validation succeeds.

* `InheritableValues#[]`: drop the per-call merge with `Hash#fetch`
  plus a fallback block. Lookup is 1.55x faster microbenched, allocates
  zero. Mostly helps boot/compile time (where ~30+ reads per endpoint
  hit this).

* `Grape::API::Instance`: rename `ROOT_PREFIX_VERSIONING_KEY` to
  `ROOT_PREFIX_VERSIONING_KEYS` (it holds 3 symbols), pair via `zip`
  instead of `each_with_index` + manual indexing.

* `Validations::Types::CustomTypeCoercer#infer_coercion_method`:
  guard-clause refactor of the nested if/else.

End-to-end, 3-run averaged on Ruby 4.0.3, arm64-darwin25, against
`/api/v1/hello` returning a small JSON object:

                       no-yjit       yjit
  master HEAD:         52,088 i/s    101,563 i/s
  master + this PR:    57,433 i/s    107,982 i/... (continued)

Pull Request Pull Request #2696: Reduce per-request allocations on the request hot path

Coverage Stats

1077 of 1161 branches covered (92.76%)

Branch coverage included in aggregate %.

65 of 66 new or added lines in 11 files covered. (98.48%)

4 existing lines in 3 files now uncovered.

3361 of 3415 relevant lines covered (98.42%)

32315.89 hits per line