Freegle / Iznik / 8700

72%

master: 70%

Build Type

Pull #307

circleci

Committed by edwh

Commit Message

fix(test): use real mod_configs ID in ConfigidNull and ConfigidZero tests

Both TestPatchMembershipsSettingsConfigidNull and TestPatchMembershipsSettingsConfigidZero
pre-set memberships.configid = 99 before testing the clearing behaviour, but configid
has a FK constraint referencing mod_configs(id). No row with id=99 exists so the UPDATE
silently fails, leaving configid NULL. The tests then assert Nil — which trivially passes
because configid was never set, not because the PATCH handler cleared it.

Fix: create a real mod_configs entry with createTestModConfig and pre-set configid to
that real ID before the PATCH request. The tests now actually verify that sending
configid: null (nil branch) and configid: 0 (else branch) in the settings JSON clears
the dedicated configid column.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Pull Request Pull Request #307: fix: standard message delete 404 and group standard message config not persisting

Coverage Stats

13625 of 20613 branches covered (66.1%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 2 files covered. (100.0%)

20 existing lines in 4 files now uncovered.

98397 of 134277 relevant lines covered (73.28%)

22.33 hits per line