decentraland / lamb2 / 25188962240

83%

main: 81%

Pull #462

github

test: align ported-endpoint specs with the dcl-testing skill

reshapes the unit and integration specs added in this pr to follow
the team's testing conventions:

- describe blocks use 'when' for top-level contexts and 'and' for
  nested variants ('when ?includeDefinitions is set' -> 'and the
  definitions fetcher resolves a definition for the owned urn').
- it() descriptions name a single specific outcome instead of generic
  'should throw InvalidRequestError' / 'responds 400'. multiple
  expects are kept only when they describe a single behavior.
- mocks, request objects, response bodies, and fixtures move out of
  it() bodies into the enclosing describe's beforeEach. mutable state
  is `let`-declared at describe scope and assigned per-test.
- mocks are scoped to the describe context that uses them. shared
  setup (graph spies, content client mock) stays in the suite-level
  beforeEach because it applies to every variant.
- afterEach calls jest.resetAllMocks() in every spec to keep tests
  isolated.

split compound it()s into per-assertion cases where the original was
testing several behaviors at once (e.g. 'returns 200 with body X and
calls fetcher Y' is now two its). full suite is 557 passing (was 511);
only the pre-existing ownership.spec.ts failure remains.

715 of 958 branches covered (74.63%)

Branch coverage included in aggregate %.

205 of 208 new or added lines in 12 files covered. (98.56%)

2026 of 2348 relevant lines covered (86.29%)

47.56 hits per line