stacklok / toolhive / 25154936592

65%

Build Type

push

github

Committed by web-flow

Commit Message

Auto-detect Docker Desktop socket on Linux (#5122)

* Auto-detect Docker Desktop socket on Linux

Docker Desktop on Linux exposes its Engine socket at
$HOME/.docker/desktop/docker.sock and registers a desktop-linux
Docker context pointing there. ToolHive runtime auto-detection
only probed /var/run/docker.sock and macOS-specific paths, so on
a Linux host with only Docker Desktop installed IsAvailable
returned false and CheckRuntimeAvailable failed with "no
container runtime available" -- even though docker ps in the
same shell worked fine via the active context.

Add the Linux Docker Desktop socket to the discovery list so
auto-detection finds it without requiring TOOLHIVE_DOCKER_SOCKET.
Wrap the system socket path in an unexported package variable
so tests can redirect the system probe to a sandbox path.

* Add unit tests for Docker socket discovery

Cover three cases for Docker socket auto-detection:

- discovery of the new Docker Desktop on Linux socket at
  $HOME/.docker/desktop/docker.sock when no system socket
  is present;
- TOOLHIVE_DOCKER_SOCKET env override wins over filesystem
  discovery;
- ErrRuntimeNotFound when no socket is reachable.

The tests redirect the system socket probe via the unexported
systemDockerSocketPath variable so they stay hermetic on
machines that already have /var/run/docker.sock.

* Document Docker Desktop on Linux socket path

Match the documented runtime discovery order to the code by
adding the Linux Docker Desktop socket path next to the
existing macOS-specific entries in
docs/arch/01-deployment-modes.md.

Coverage Stats

14 of 14 new or added lines in 1 file covered. (100.0%)

10 existing lines in 3 files now uncovered.

61152 of 95135 relevant lines covered (64.28%)

59.36 hits per line