stacklok / toolhive / 25154213341

65%

Build Type

push

github

Committed by web-flow

Commit Message

Add --tls-skip-verify flag to thv llm setup, config set, and proxy start (#5136)

Closes #5123

Stores TLSSkipVerify in the LLM config section and threads it through to
every layer:

- pkg/llm/config.go: add TLSSkipVerify field to Config; SetOptions uses
  *bool so that --tls-skip-verify=false explicitly clears the stored value
  rather than being silently ignored as a zero value
- pkg/llm/manage.go: SetFields applies the pointer, Show() prints a WARNING
  line when the flag is set
- pkg/llm/setup.go: pass TLSSkipVerify through ToolApplyConfig; extract
  configureDetectedTools() and warnTLSSkipVerify() helpers (gocyclo)
- pkg/llm/proxy/proxy.go: add Option / WithTLSSkipVerify() functional
  option; New() accepts variadic opts; sets InsecureSkipVerify on the
  upstream transport when the flag is true
- pkg/client/llm_gateway.go: add TLSSkipVerify to LLMApplyConfig; add
  NodeTLSRejectUnauthorized case to llmValueForSpec(); extract
  applyLLMGatewayKeys / addLLMKey / removeLLMKey helpers (gocyclo);
  ClearWhenEmpty on LLMGatewayKeySpec removes the JSON key when the flag
  is cleared rather than leaving a stale "0" in the settings file
- pkg/client/config.go: add NODE_TLS_REJECT_UNAUTHORIZED key spec
  (ClearWhenEmpty=true) to ClaudeCode and GeminiCli (the two direct-mode
  Node.js tools); proxy-mode tools (Cursor, VSCode, Xcode, …) are covered
  by WithTLSSkipVerify on the proxy transport
- cmd/thv/app/llm.go: wire --tls-skip-verify into setup, config set, and
  proxy start; proxy start overrides the stored value when the flag is
  explicitly passed

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Coverage Stats

99 of 170 new or added lines in 6 files covered. (58.24%)

8 existing lines in 5 files now uncovered.

61123 of 95125 relevant lines covered (64.26%)

58.64 hits per line