cpmpercussion / impsy / 25150347458

82%

Build Type

push

github

Committed by cpmpercussion

Commit Message

Fix WebSocket channel handling and gate debug print

Three fixes in WebSocketServer:

1. Channel translation: outgoing messages now use 1-based channels
   (mido.channel + 1) on the wire so they match the MIDI config
   convention. The receiver was already reading channels as 1-based;
   the outgoing side was sending 0-based, so echo-back round-trip was
   broken. Existing test asserting "/channel/0/noteon/..." for mido
   channel=0 was locking in the bug — updated to "/channel/1/...".

2. Input lookup: websocket_handler was indexing self.config["midi"]
   ["input"], but since multi-MIDI-port support that key is now a
   per-device dict, not a flat list. Switched to self.midi_input_mapping
   (the [websocket].input mapping) which the constructor already stores.

3. Debug print: WS message logging is now gated on self.verbose
   instead of always printing every message in red.

New round-trip regression test feeds output of websocket_send_midi
back through websocket_handler and asserts the index/value land in the
right slot.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

9 of 10 new or added lines in 1 file covered. (90.0%)

1 existing line in 1 file now uncovered.

1311 of 1598 relevant lines covered (82.04%)

2.46 hits per line