iotaledger / iota / 25142798011
63%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1215
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 63.149% (+0.009%) from 63.14%
25142798011

push

github

web-flow 
chore: Replace `Identifier`, `StructTag` and `TypeTag` with SDK versions (#10075) (#11355)

This PR is part of the ongoing effort to consolidate blockchain types in
the
canonical `iota-rust-sdk`. Types that are needed by both clients/SDK
consumers
and the node should live in `iota-rust-sdk` and be imported from there,
instead
of being defined twice (once in `iota-types`, once in the SDK).

This PR replaces `Identifier`, `StructTag` and `TypeTag` (previously
sourced
from `move-core-types` and re-exported through `iota-types`) with the
SDK
versions from `iota-sdk-types`. To keep the diff small and avoid
touching
every call site, the SDK types are re-exported from
`iota-types::base_types`
under the original names `Identifier`, `StructTag` and `TypeTag`, so
most
existing imports continue to work unchanged. The `move-core-types`
definitions
are intentionally not removed — they are still used internally by the
Move VM
(e.g. in `MoveStructLayout` / `MoveValue` / `ModuleId`), and conversion
helpers bridge between the two representations at the boundary.

## Description of change

- `iota-types::base_types` now re-exports `iota_sdk_types::{Identifier,
StructTag, TypeTag}`; imports of
`move_core_types::{identifier::Identifier, language_storage::{StructTag,
TypeTag}}` across the workspace have been replaced with the SDK
versions.
- Helpers and constants that previously lived on the local types are
gone in favour of the SDK API:
- `Coin::type_(t)` / `Coin::is_coin(s)` → `StructTag::new_coin(t)` /
`StructTag::is_coin(s)`.
- `TreasuryCap::type_(t)` / `CoinMetadata::type_(t)` /
`Balance::type_(t)` / `GAS::type_()` / `StakedIota::type_()` etc. →
`StructTag::new_treasury_cap(...)` / `StructTag::new_coin_metadata(...)`
/ `StructTag::new_balance(...)` / `StructTag::new_gas()` /
`StructTag::new_staked_iota()`, etc.
- `COIN_MODULE_NAME` / `COIN_STRUCT_NAME` / `STAKING_POOL_MODULE_NAME` /
`STAKED_IOTA_STRUCT_NAME`, … → `Identifier::COIN_MODULE` /
`Identifier::COIN` / `Iden... (continued)

801 of 1148 new or added lines in 143 files covered. (69.77%)

630 existing lines in 53 files now uncovered.

156239 of 247414 relevant lines covered (63.15%)

452915.17 hits per line

Uncovered Changes

Lines Coverage ∆ File
86
40.99
 -0.3% crates/iota-package-resolver/src/lib.rs
36
0.0
 0.0% crates/iota-core/src/generate_format.rs
26
33.96
 2.63% crates/iota-types/src/iota_sdk_types_conversions.rs
18
84.1
 -2.76% crates/iota-types/src/base_types.rs
11
0.0
 0.0% crates/iota-benchmark/src/workloads/abstract_account/utils.rs
11
0.0
 0.0% crates/iota-indexer/src/read.rs
11
71.23
 -0.44% crates/iota-json/src/lib.rs
9
0.0
 0.0% crates/iota-benchmark/src/workloads/randomized_transaction.rs
9
73.67
 0.0% crates/iota-graphql-rpc/src/types/type_filter.rs
8
52.39
 -0.21% crates/iota-json-rpc-types/src/iota_object.rs
7
0.0
 0.0% crates/iota-graphql-rpc/src/types/event/lookups.rs
7
0.0
 0.0% crates/iota-open-rpc/src/examples.rs
6
0.0
 0.0% crates/iota-graphql-rpc/src/data/package_resolver.rs
5
88.63
 -0.34% crates/iota-genesis-builder/src/lib.rs
5
0.0
 0.0% crates/iota-indexer/src/store/package_resolver.rs
5
8.06
 0.0% crates/iota-indexer/src/types.rs
4
0.0
 0.0% crates/iota-graphql-rpc/src/types/dynamic_field.rs
4
40.12
 -4.63% crates/iota-types/src/dynamic_field.rs
3
0.0
 0.0% crates/iota-graphql-rpc/src/types/coin_metadata.rs
3
0.0
 0.0% crates/iota-graphql-rpc/src/types/move_package.rs
3
19.05
 0.87% crates/iota-types/src/layout_resolver.rs
3
86.12
 0.72% crates/iota-types/src/test_checkpoint_data_builder.rs
3
54.55
 -6.99% crates/iota-types/src/timelock/stardust_upgrade_label.rs
3
80.6
 -0.27% crates/iota-types/src/transaction.rs
3
60.9
 0.0% crates/simulacrum/src/lib.rs
2
0.0
 0.0% crates/iota-analytics-indexer/src/package_store.rs
2
82.76
 0.0% crates/iota-grpc-server/src/event_filter.rs
2
86.47
 0.0% crates/iota-grpc-server/src/ledger_service/get_checkpoint.rs
2
34.4
 -0.48% crates/iota-indexer/src/models/objects.rs
2
0.0
 0.0% crates/iota-names/src/lib.rs
2
55.16
 0.0% crates/iota-replay/src/replay.rs
2
82.76
 0.2% crates/iota-source-validation/src/lib.rs
2
80.88
 0.0% crates/iota-transaction-builder/src/stake.rs
2
45.93
 0.0% crates/iota-transactional-test-runner/src/simulator_persisted_store.rs
2
55.0
 5.0% crates/iota-types/src/config.rs
2
0.0
 -22.86% crates/iota-types/src/display.rs
2
69.54
 0.06% crates/iota/src/client_commands.rs
2
84.46
 0.0% iota-execution/latest/iota-adapter/src/temporary_store.rs
1
0.0
 0.0% crates/iota-analytics-indexer/src/handlers/df_handler.rs
1
0.0
 0.0% crates/iota-analytics-indexer/src/handlers/event_handler.rs
1
0.0
 0.0% crates/iota-benchmark/src/workloads/abstract_account/payload.rs
1
0.0
 0.0% crates/iota-benchmark/src/workloads/adversarial.rs
1
82.5
 0.0% crates/iota-config/src/genesis.rs
1
89.44
 -0.56% crates/iota-genesis-builder/src/stardust/migration/verification/foundry.rs
1
0.0
 0.0% crates/iota-graphql-rpc/src/server/system_package_task.rs
1
0.0
 0.0% crates/iota-graphql-rpc/src/types/balance.rs
1
0.0
 0.0% crates/iota-graphql-rpc/src/types/coin.rs
1
83.14
 0.12% crates/iota-graphql-rpc/src/types/move_value.rs
1
0.0
 0.0% crates/iota-graphql-rpc/src/types/stake.rs
1
67.68
 -0.2% crates/iota-grpc-server/src/state_service/list_dynamic_fields.rs
1
91.82
 -0.11% crates/iota-grpc-server/src/transaction_execution_service/transaction.rs
1
0.0
 0.0% crates/iota-indexer/src/ingestion/common/prepare.rs
1
0.0
 0.0% crates/iota-indexer/src/system_package_task.rs
1
50.75
 0.25% crates/iota-json-rpc-types/src/iota_event.rs
1
68.93
 -0.02% crates/iota-json-rpc/src/indexer_api.rs
1
0.0
 0.0% crates/iota-light-client/src/package_store.rs
1
55.17
 0.0% crates/iota-names/src/config.rs
1
47.87
 -0.16% crates/iota-replay/src/data_fetcher.rs
1
0.0
 0.0% crates/iota-replay/src/displays/transaction_displays.rs
1
79.12
 4.03% crates/iota-sdk/src/wallet_context.rs
1
2.33
 0.0% crates/iota-source-validation/src/toolchain.rs
1
89.47
 -0.06% crates/iota-test-transaction-builder/src/lib.rs
1
0.0
 0.0% crates/iota-tool/src/db_tool/index_search.rs
1
84.29
 0.0% crates/iota-transaction-checks/src/lib.rs
1
92.21
 0.0% crates/iota-types/src/inner_temporary_store.rs
1
91.56
 1.42% crates/iota-types/src/lib.rs
1
80.93
 0.64% crates/iota-types/src/object.rs
1
75.0
 16.94% crates/iota-types/src/transfer.rs
1
80.0
 0.65% crates/iota/src/client_ptb/ast.rs
1
56.67
 0.0% iota-execution/latest/iota-adapter/src/type_layout_resolver.rs

Coverage Regressions

Lines Coverage ∆ File
187
69.94
 5.18% crates/iota-core/src/grpc_indexes.rs
83
77.26
 0.15% crates/iota-core/src/checkpoints/mod.rs
75
33.96
 2.63% crates/iota-types/src/iota_sdk_types_conversions.rs
47
94.16
 0.0% crates/starfish/core/src/authority_service.rs
32
75.27
 -2.34% crates/test-cluster/src/lib.rs
18
88.94
 0.06% crates/starfish/core/src/subscriber.rs
16
89.47
 -0.06% crates/iota-test-transaction-builder/src/lib.rs
14
52.39
 -0.21% crates/iota-json-rpc-types/src/iota_object.rs
10
60.47
 -0.28% crates/iota-json-rpc-types/src/iota_transaction.rs
9
83.61
 -14.75% crates/iota-grpc-client/src/api/execution/simulate.rs
9
80.6
 -0.27% crates/iota-types/src/transaction.rs
8
81.73
 -2.56% crates/iota-grpc-types/src/proto/generated/iota.grpc.v1.ledger_service.accessors.rs
8
40.99
 -0.3% crates/iota-package-resolver/src/lib.rs
8
51.88
 -1.37% crates/iota-sdk/src/apis/read.rs
8
42.86
 -7.14% crates/iota-types/src/collection_types.rs
6
81.34
 -0.19% crates/iota-core/src/authority.rs
6
90.91
 -0.63% crates/iota-types/src/gas.rs
5
88.63
 -0.34% crates/iota-genesis-builder/src/lib.rs
5
89.34
 -4.1% crates/iota-transaction-builder/src/package.rs
4
70.36
 -0.32% crates/iota-core/src/authority/authority_store.rs
4
87.25
 -1.34% crates/iota-core/src/authority/test_authority_builder.rs
4
85.29
 -11.76% crates/iota-grpc-client/src/api/ledger/transactions.rs
4
58.23
 -1.61% crates/iota-grpc-types/src/proto/generated/iota.grpc.v1.filter.accessors.rs
4
63.48
 0.0% crates/iota-grpc-types/src/proto/generated/iota.grpc.v1.state_service.accessors.rs
4
21.13
 0.0% crates/iota-grpc-types/src/proto/iota/grpc/v1/transaction_execution_service.rs
4
85.5
 0.0% crates/iota-transaction-builder/src/lib.rs
3
77.05
 -4.92% crates/iota-core/src/traffic_controller/nodefw_test_server.rs
3
49.56
 0.0% crates/iota-genesis-builder/src/stardust/types/snapshot.rs
3
82.14
 0.0% crates/iota-genesis-builder/src/validator_info.rs
3
75.0
 -2.88% crates/iota-grpc-server/src/server.rs
3
79.37
 -1.05% crates/iota-sdk/src/lib.rs
3
78.19
 -0.34% crates/iota-types/src/crypto.rs
3
80.37
 -0.93% crates/iota-types/src/multisig.rs
3
84.21
 -3.16% crates/starfish/config/src/crypto.rs
2
91.56
 -0.09% crates/iota-core/src/authority/authority_per_epoch_store.rs
2
89.35
 -0.34% crates/iota-core/src/connection_monitor.rs
2
90.82
 -0.28% crates/iota-core/src/epoch/randomness.rs
2
84.1
 -2.76% crates/iota-types/src/base_types.rs
2
21.74
 -28.26% crates/iota-types/src/coin_manager.rs
1
0.0
 0.0% crates/iota-benchmark/src/workloads/abstract_account/utils.rs
1
81.14
 0.23% crates/iota-core/src/authority_server.rs
1
0.0
 0.0% crates/iota-graphql-rpc/src/types/event/lookups.rs
1
0.0
 0.0% crates/iota-names/src/lib.rs
1
86.47
 -0.75% crates/iota-network-stack/src/grpc_timeout.rs
1
69.54
 0.06% crates/iota/src/client_commands.rs
1
55.0
 5.0% crates/iota-types/src/config.rs
1
0.0
 -22.86% crates/iota-types/src/display.rs
1
87.88
 4.01% crates/iota-types/src/gas_coin.rs
1
80.93
 0.64% crates/iota-types/src/object.rs
1
54.55
 -6.99% crates/iota-types/src/timelock/stardust_upgrade_label.rs
1
89.09
 -0.1% crates/iota-types/src/timelock/timelock.rs
1
96.86
 0.0% crates/starfish/core/src/cordial_knowledge.rs
1
93.48
 -0.07% crates/starfish/core/src/transactions_synchronizer.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 25142798011.1 1215
63.15
 GitHub Action Run
Source Files on build 25142798011