lsm / neokai / 25134578523

82%

push

github

Delete Room E2E specs, tests, and docs; mark remaining files as legacy (#1718)

* Delete Room E2E specs, tests, and docs; mark remaining files as legacy

Task #186: Room feature retirement — final cleanup and validation sweep.

### Deleted files (~55k lines removed):
- **E2E specs**: room-helpers.ts, reference-helpers.ts, and all 21 E2E specs
  that tested Room behavior (room-sidebar-*, room-skills.e2e.ts,
  task-*.e2e.ts, mission-*.e2e.ts, navigation-3-column.e2e.ts,
  reference-autocomplete.e2e.ts, neo-conversation.e2e.ts, etc.)
- **E2E helpers updated**: mobile.e2e.ts (removed Room agent navigation block),
  session-archive-helpers.ts and settings-modal-helpers.ts (NavRail comments
  updated from "Rooms" to "Spaces"), wait-helpers.ts and selectors.ts
  (room-role references removed)
- **Daemon online tests**: 18 files in tests/online/room/
- **Daemon unit tests**: 56 files in tests/unit/2-handlers/room/,
  room-tick-handler.test.ts, goal-handlers.test.ts, room-handlers.test.ts,
  room-runtime-model-handlers.test.ts, task-handlers.test.ts

### Modified files:
- **CLAUDE.md**: Updated Skills System, E2E allowed exceptions (room.* →
  space.*), Space tool surface, AttachSpaceToolsToMemberSession notes,
  Mission System intro — all removed Room-as-active-surface language
- **docs/design/room-runtime-impl-plan.md** and
  **docs/design/room-runtime-spec.md**: Added "⚠️ Retired feature" warning
  header; spec updated status to "Historical (retired 2026-04)"
- **docs/plans/complete-room-human-in-a-loop-features.md**: Added retired
  warning header
- **docs/features/skills.md**: "per room" → "per Space" throughout;
  room-scoped overrides noted as legacy DB compatibility only
- **packages/daemon/tests/unit/1-core/session/**: Updated comments removing
  room.delete references
- **packages/web/src/components/settings/**: Minor text updates
- **knip.json**: Added legacy Room source files to ignore list

### Intentionally retained (legacy DB compatibility only)... (continued)

7670 of 10003 branches covered (76.68%)

Branch coverage included in aggregate %.

58219 of 82015 relevant lines covered (70.99%)

274.5 hits per line