decentraland / lamb2 / 25133709400

83%

main: 83%

Pull #462

github

test: cover the remaining filter combinations end-to-end

the existing integration suite only exercised textsearch on the
catalogs and the no-?includedefinitions / non-third-party-error
branches on the by-owner endpoints. fills the gaps end-to-end
through the real router + middleware + handler chain:

wearables catalog (test/integration/wearables-catalog-handler.spec.ts):
- collectionid alone -> the on-chain query wraps items inside a
  collections(where: { urn_in: $collectionids }) block and the
  filters echo back as { collectionids: [...] }.
- wearableid alone -> uses urn_in: $ids without the collections
  wrapper.
- combined collectionid + textsearch -> both filters land in the
  graphql variables and the response echoes both.
- collectionid = base avatars only -> served entirely from
  fetchbasewearables, neither collection subgraph is hit.

emotes catalog (test/integration/emotes-catalog-handler.spec.ts):
- collectionid -> wraps items inside collections() on the l2
  subgraph and never touches l1.
- emoteid -> urn_in on the l2 subgraph; query restricts to
  emote_v1.

by-owner (wearables and emotes):
- ?includedefinitions -> the response carries a definition object
  on every entry, sourced through the content client mock.

506 -> 510 passing tests across the 4 integration suites; pre-
existing ownership.spec.ts failure unchanged.

714 of 957 branches covered (74.61%)

Branch coverage included in aggregate %.

199 of 202 new or added lines in 11 files covered. (98.51%)

2021 of 2343 relevant lines covered (86.26%)

42.4 hits per line