thoughtspot / mcp-server / 25127974304

89%

push

github

SCAL-308277 Add metrics recorder core (#119)

* SCAL-308277 Add metrics recorder core

## Summary

Introduce the request-scoped metrics runtime core for the Worker and add
focused tests so the new runtime metrics files do not regress repo
coverage.

## What Changed

- add metric definitions, label normalization, and runtime config for sink
  selection
- add the request-scoped recorder, sink interfaces, composite/noop sinks,
  and context helpers
- wrap the Worker fetch entrypoint so every request gets a recorder and
  non-blocking flush behavior
- add targeted tests for metric context, sink behavior, recorder branches,
  runtime config, and request-scoped recorder helpers

## Notes

- this PR only adds the runtime core, request wrapper plumbing, and tests
- external Analytics Engine and Grafana emission lands in follow-up PRs

## Validation

- `npm test -- --coverage.enabled=false test/metrics/runtime`
- `npm test`

* SCAL-308277 Fix recorder flush race

## Summary

Close the recorder as soon as flush begins, add coverage for the in-flight
flush case, and address the follow-up lint and label-policy feedback.

## What Changed

- mark the recorder flushed before awaiting the sink and snapshot observations
  once
- add a test that rejects metrics recorded after flush has started
- document why forbidden metric label keys stay explicit
- remove the redundant `both` switch case flagged by Biome

## Validation

- `npm run lint`
- `npm test`

* Refine request metrics routing context

## Summary

Strip tracing headers before metrics setup and centralize route metric
classification so request metrics are easier to maintain as routes evolve.

## What Changed

- move tracing header stripping ahead of `withRequestMetrics(...)` in the
  Worker entrypoint
- replace duplicated metric path classification helpers with a shared explicit
  route-context table and resolver
- expand focused metric-context tests to cover the shared route metadata and
  fallback behavior

#... (continued)

469 of 550 branches covered (85.27%)

Branch coverage included in aggregate %.

186 of 193 new or added lines in 10 files covered. (96.37%)

1151 of 1287 relevant lines covered (89.43%)

343.21 hits per line