decentraland / lamb2 / 25123307219

83%

main: 83%

Build Type

Pull #462

github

Committed by LautaroPetaccio

Commit Message

refactor: use @dcl/schemas AuthChain validator in validate-signature

drops the hand-rolled isAuthLink/array.isarray checks in favor of the
ajv validator already shipped in @dcl/schemas (a direct dep, also
re-exported by @dcl/crypto so the runtime types are identical).

what stays:
- the json-object check (the body wrapping is not part of the schema).
- the length cap of 10 (cost-amplification policy, not schema-level).
- the timestamp/signedmessage type checks (these live alongside, not
  inside, the authchain).

what changes:
- the schema validator covers more than the manual guard did:
  authlinktype enum membership, the at-least-1-item rule (which
  duplicates one half of our length cap), and field-by-field type
  checks for type/payload/signature.
- it also corrects an over-strict guard: signature is optional in the
  schema (signer links legitimately have no signature). the test that
  previously rejected a missing signature is replaced by one that
  rejects a non-string signature instead, which is what the schema
  itself catches.
- the empty-authchain test now matches the schema's "must not have
  fewer than 1 items" message rather than the length-cap fallback,
  since the validator runs first.

Pull Request Pull Request #462: feat: implement legacy lambdas endpoints in lamb2

Coverage Stats

727 of 972 branches covered (74.79%)

Branch coverage included in aggregate %.

209 of 212 new or added lines in 10 files covered. (98.58%)

5 existing lines in 1 file now uncovered.

2032 of 2354 relevant lines covered (86.32%)

40.79 hits per line