codenotary / immudb / 25120451743

85%

Build Type

push

gh-ci

Committed by vchaindz

Commit Message

fix: three correctness issues found in v1.11.0 verification sweep

Three independent bug fixes prompted by re-verifying long-open issues against
master after the v1.11.0 release.

#2042: standalone COUNT(col) returned 0 instead of the row count
-----------------------------------------------------------------
CountValue.ColBounded() returned true only for COUNT(DISTINCT col), so
plain COUNT(col) hit updateRow's !ColBounded branch and got updateWith(nil),
which the null-skip path then declined to count. The bug was masked when
COUNT(col) appeared alongside COUNT(DISTINCT col) in the same SELECT
because both share the same encoded selector slot — TestCountColSkipsNulls
incidentally passed via that overwrite. Standalone COUNT(col) was silently
broken (returned 0 for any non-empty table).

Fix: ColBounded now returns !v.allRows so COUNT(col) and COUNT(DISTINCT col)
both fetch the column value, preserving SQL NULL-skip semantics. Updated
TestCountValue (zero-value CountValue now models COUNT(*)) and extended
TestCountColSkipsNulls with the standalone-COUNT(col) shape from #2042.

#1149: TIMESTAMP parameter binds with a tz suffix were rejected
---------------------------------------------------------------
lib/pq and JDBC's setTimestamp emit "YYYY-MM-DD HH:MM:SS.fff[fff[fff]]Z"
or with "±HH:MM" when the time.Time carries a location. pgTextTimestamp
only accepted the RFC3339 (T-separated) form for tz-bearing values, so
the Bind path errored with "invalid timestamp bind value".

Fix: add the space-separated layouts with Z07:00 (covers Z, ±HH:MM,
±HHMM, ±HH). Added Test_pgTextTimestamp coverage and a PG-wire
integration subtest under TestPgsqlServer_F1DBCompatRegressions.

#1153: parametrized SELECT WHERE was pinned to the first bound value
---------------------------------------------------------------------
The pgsql wire layer caches parsed statements per session. The boolean-
expression substitute() methods (CmpBoolExp, NumExp, NotBoolExp,
BinBoolExp, Cast... (continued)

Coverage Stats

22 of 22 new or added lines in 2 files covered. (100.0%)

8 existing lines in 3 files now uncovered.

44613 of 52334 relevant lines covered (85.25%)

127531.09 hits per line