codenotary / immudb / 25055790955

85%

Build Type

push

gh-ci

Committed by vchaindz

Commit Message

feat(auditor): add opt-in --audit-verify-values for on-disk value integrity

Previously, immuclient audit-mode only verified the cryptographic
chain-of-custody (state-root chain via VerifyDualProof) and never re-read
entry values. As a result, hex-editing a .val file after commit was not
detected by audit-mode, even though `get`/`safeget` correctly flagged the
tampering at read time (issue #2091).

audit-mode and on-disk value integrity are different threat models, so
fixing audit-mode in place would conflate them and slow the default audit
significantly. Instead, this change adds a new opt-in flag.

When --audit-verify-values is set, after each successful chain check the
auditor calls TxById with EntriesSpec.RAW_VALUE for each tx committed
since the last audited state. Server-side this routes through
db.serializeTx -> store.ReadValue -> readValueAt, which computes
sha256 over each value read from disk and compares it to the committed
hash. Any mismatch surfaces as ErrCorruptedData and the audit cycle is
marked failed.

Default behavior (flag unset) is unchanged.

Closes #2091

Coverage Stats

21 of 39 new or added lines in 1 file covered. (53.85%)

10 existing lines in 2 files now uncovered.

44609 of 52330 relevant lines covered (85.25%)

127829.27 hits per line