kubevirt / hyperconverged-cluster-operator / 25100572106

81%

Build Type

push

github

Committed by web-flow

Commit Message

Fix two bugs (#4206)

* Fix bug in the validatingAdmissionPolicy

The validatingAdmissionPolicy that force the HyperConverged namespace is
only checks the v1beta1 HyperConverged, and ignores the v1 one.

This commit fixes it.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

* Fix a bug on on watching nodes

The nodes controller is always started, and is using a channel to
trigger events in the hyperconverged controller. But the hyperconverged
controller only watches this channel if running on openshift, so the
full logic does not work in plain kubernetes. It's also blocks the nodes
controller, because nothing is reading from the channel.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

---------

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>

Coverage Stats

1 of 15 new or added lines in 2 files covered. (6.67%)

1 existing line in 1 file now uncovered.

10681 of 13268 relevant lines covered (80.5%)

2.07 hits per line