dcdpr / jp / 25080314439

66%

push

github

perf(cli, workspace): Parallelize `conversation grep` with rayon (#587)

The grep command previously used a two-phase approach for workspace-wide
searches: eagerly pre-loading all conversation event streams in parallel
via `ensure_all_events_loaded`, then sequentially iterating over
results. This coupling required `Workspace` to own parallelism logic it
shouldn't need to care about.

The new approach is simpler and more direct: `collect_hits` now takes
`&Ctx` (no longer `&mut`) and fans out over conversation IDs using
`rayon::par_iter`. Each conversation is handled by
`collect_hits_for_id`, a pure per-ID function that loads and searches
its own event stream independently. Rayon's order-preserving `collect`
on `Vec<Vec<Hit>>` keeps the pre-sorted ID order intact after
flattening.

As a result, `Workspace::ensure_all_events_loaded` is removed entirely,
along with the distinction between "workspace-wide" and "narrow" search
paths.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

53 of 60 new or added lines in 1 file covered. (88.33%)

23432 of 36478 relevant lines covered (64.24%)

261.09 hits per line