dcdpr / jp / 25076211620

66%

push

github

refactor(config, cli): Rename `user_global_config_path` to `*_dir` (#586)

The function `user_global_config_path` in `jp_config::fs` was
misleadingly named — it returns a directory path, not a file path.
Rename it to `user_global_config_dir` to accurately reflect its purpose,
and rename the associated environment variable from
`JP_GLOBAL_CONFIG_FILE` to `JP_GLOBAL_CONFIG_DIR` for the same reason.

The old function also contained logic to detect whether the env var
pointed to a file (extracting the stem and adjusting the loader), which
was fragile and inconsistent. That logic is removed; callers now receive
a clean directory path and are responsible for appending the appropriate
file name (e.g. `config.toml`).

All call sites in `jp_cli` are updated accordingly, and the RFD 035
document is updated to reference the renamed function.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

2 of 6 new or added lines in 5 files covered. (33.33%)

23435 of 36496 relevant lines covered (64.21%)

237.7 hits per line