• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stillwater-sc / universal / 25056252254
84%
master: 84%

Build:
Build:
LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran 28 Apr 2026 02:08PM UTC
Jobs 1
Files 648
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

28 Apr 2026 01:39PM UTC coverage: 84.304% (-0.05%) from 84.354%
25056252254

push

github

web-flow
fix(lns): per-algorithm tolerance for add/sub regression suite (#788)

* fix(lns): reorganizing the lns add/sub algorithm swap

* feat(lns): log-domain bound helper

* fix(lns): test suite cleanup post-reorganization (CodeRabbit)

Address CodeRabbit findings on PR #788 -- all in code from the
reorganization commit 7af6f4fb, none in the tolerance helper itself:

1. lns_test_suite.hpp: header comment said "blockfraction_test_suite.hpp"
   (copy-paste leftover). Fix to lns_test_suite.hpp.

2. lns_test_suite.hpp: out-of-range diagnostic messages all printed
   " * " regardless of the actual op. Fix per-verifier:
   - VerifyAddition uses " + "
   - VerifySubtraction uses " - "
   - VerifyMultiplication uses " * " (already correct)
   - VerifyDivision uses " / "

3. lns_test_suite.hpp: VerifySubtraction had an inconsistent early-return
   pattern (bailed at nrOfFailedTestCases > 0, returned literal 25)
   relative to the other three verifiers. Align to the standard
   nrOfFailedTestCases > 24 / return nrOfFailedTestCases pattern.
   Drive-by: VerifyDivision had the right bound but also returned
   literal 25; aligned for consistency.

4. log_add_algorithms.cpp: MANUAL_TESTING block referenced LNS4_2_sat
   which was not in scope (would fail to compile when MANUAL_TESTING=1).
   Add the local using-alias.

All 5 lns regression targets pass on gcc and clang.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(lns): multiplication off-by-one + manual-test exit + canonical include (CodeRabbit)

Address CodeRabbit follow-up findings on PR #788:

1. lns_test_suite.hpp: VerifyMultiplication had an off-by-one early-return
   threshold (> 25 vs the > 24 used by Addition/Subtraction/Division), so it
   would collect one extra failure before bailing. Align to > 24.

2. log_add_algorithms.cpp: the MANUAL_TESTING block returned an unconditional
   EXIT_SUCCESS, which would hide failures from the test runner. Replace with
   the same conditional ... (continued)

115 of 155 new or added lines in 3 files covered. (74.19%)

22 existing lines in 4 files now uncovered.

45718 of 54230 relevant lines covered (84.3%)

6248193.84 hits per line

Uncovered Changes

Lines Coverage ∆ File
30
74.14
include/sw/universal/verification/lns_test_suite.hpp
10
93.87
-3.41% include/sw/universal/number/lns/lns_addsub_algorithms.hpp

Coverage Regressions

Lines Coverage ∆ File
11
88.54
-11.46% include/sw/universal/number/lns/manipulators.hpp
5
50.45
-4.5% include/sw/universal/verification/posit_test_suite_randoms.hpp
4
80.58
-0.89% include/sw/universal/number/posit1/specialized/posit_16_1.hpp
2
89.8
-0.57% include/sw/universal/number/posito/posito_impl.hpp
Jobs
ID Job ID Ran Files Coverage
1 25056252254.1 28 Apr 2026 02:08PM UTC 648
84.3
GitHub Action Run
Source Files on build 25056252254
  • Tree
  • List 648
  • Changed 7
  • Source Changed 3
  • Coverage Changed 7
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #25056252254
  • 3fd4e9fb on github
  • Prev Build on main (#25025250568)
  • Next Build on main (#25077144174)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc