kobotoolbox / kpi / 25055583285

82%

master: 76%

push

github

fix(submissions): return 400 error message from OpenRosa for an invalid deprecatedID DEV-1807 (#6942)

### 🗒️ Checklist

1. [X] run linter locally
2. [X] update developer docs (API, README, inline, etc.), if any
3. [X] for user-facing doc changes create a Zulip thread at `#Support
Docs Updates`, if any
4. [X] draft PR with a title `<type>(<scope>)<!>: <title> DEV-1234`
5. [X] assign yourself, tag PR: at least `Front end` and/or `Back end`
or `workflow`
6. [X] fill in the template below and delete template comments
7. [X] review thyself: read the diff and repro the preview as written
8. [X] open PR & confirm that CI passes & request reviewers, if needed
9. [ ] delete this section before merging

### 📣 Summary
Updated the submission process to return a clear error message when an
edit is attempted with an invalid ID, preventing a system crash when a
record cannot be found.

### 👀 Preview steps

1. ℹ️ have an account and a project with at least one submission
2. Create an xml locally to use in your POST request. Use the data id
and instanceID from a submission on your project. Ex: malformed_edit.xml
```
<data id="aoFFSYk8J8ND8A5WrbYbkX">
<meta>
<instanceID>uuid:4cb7bce0-8f0b-427c-aa8c-6b13d895f251</instanceID>
<deprecatedID>uuid:this-uuid-does-not-exist-in-db</deprecatedID>
</meta>
<test_node>Testing the 500 error fix</test_node>
</data>
```
3. Make a POST request locally:
```
curl -v -X POST \
-H "Authorization: Token <your_token>" \
-H "X-OpenRosa-Version: 1.0" \
-F "xml_submission_file=@malformed_edit.xml" \
http://kf.kobo.local/submission
```
4. 🔴 [on main] Receive a 500 INTERNAL SERVER ERROR 
5. 🟢 [on PR] Receive a 400 Bad Request with this message:
```
<OpenRosaResponse xmlns="http://openrosa.org/http/response">
                <message nature="">Invalid submission - deprecatedID not found.</message>
```

9035 of 12110 branches covered (74.61%)

6 of 18 new or added lines in 2 files covered. (33.33%)

29804 of 36251 relevant lines covered (82.22%)

5.78 hits per line