umputun / ralphex / 25035377090

84%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add move_plan_on_completion config option (#307)

* docs: add move_plan_on_completion config plan

Plans part 1 of 2 for issue #306: a boolean config option (default
true) to suppress the move-to-completed step. Enables workflows that
manage plan lifecycle externally (e.g. spec-driven tooling with
separate archive steps) without coupling ralphex to any specific tool.

* feat: add MovePlanOnCompletion field to Values struct and INI loader

Introduces MovePlanOnCompletion and MovePlanOnCompletionSet fields on
the Values struct, mirroring the FinalizeEnabled pattern. Adds an INI
loader block for move_plan_on_completion and a merge block so local
config cleanly overrides global even when the explicit value is false.

Part of issue #306, task 1 of the move_plan_on_completion config plan.

* feat: add MovePlanOnCompletion to Config struct with default true

* feat: extract shouldMovePlan predicate and guard move call

Consolidates the conditions for moving a completed plan file into a single
testable helper. Wires MovePlanOnCompletion into the guard so users who
set move_plan_on_completion=false in config keep the plan file in place.

* feat: add move_plan_on_completion to embedded config template

* feat: verify acceptance criteria for move_plan_on_completion

* feat: document move_plan_on_completion option and move plan to completed

* fix: address code review findings

- guard shouldMovePlan against nil req.Config to prevent latent nil-deref
  panic in the success path of executePlan; add nil_config test case
- extend TestLoad_AllUserValues to cover move_plan_on_completion so the
  'all user values' assertion actually includes the new field

* fix: address codex review findings

* fix: address PR review findings for move_plan_on_completion

- drop nil-Config branch in shouldMovePlan (no production caller passes
  nil; was only there to satisfy a test case)
- remove MovePlanOnCompletionSet from Config — it's post-assembly state
  that nothing in pro... (continued)

Coverage Stats

61 of 67 new or added lines in 3 files covered. (91.04%)

1 existing line in 1 file now uncovered.

6749 of 8188 relevant lines covered (82.43%)

221.1 hits per line