umputun / ralphex / 24935743458

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix: resume watch-mode tailing after flock race marks session completed (#305)

* add plan: watch-mode-reactivate-tailing

* feat: add skipped TDD reproduction test for watch-mode flock race

Adds TestWatcher_ResumesStreamingAfterFlockRace to pkg/web/watcher_test.go
that reproduces issue #283: after the flock race marks a session completed,
subsequent writes to the progress file do not reactivate the session and
streaming stops.

Skipped with t.Skip so the commit stays green; verified manually that the
test fails on master when un-skipped. Will be un-skipped in Task 5 once
the reactivation fix lands, completing the red-green TDD cycle for this bug.

* feat: expose Tailer offset and StartFromOffset for resume support

Adds Offset() accessor and StartFromOffset(offset) to Tailer so callers
can capture the current read position and later resume tailing from
that byte offset without re-emitting already-processed content.
Offsets beyond EOF are clamped; offset <= 0 falls back to seek-to-end.

Groundwork for fixing watch-mode dashboard tailing after a flock race
(issue #283) — by itself this change has no runtime effect, subsequent
tasks will wire the offset through Session and Watcher.

* feat: track last-read offset on Session for resume support

add Session.lastOffset field with unexported getLastOffset/setLastOffset
accessors. StopTailing captures the tailer's current byte offset before
stopping so a subsequent Reactivate can resume from the exact byte where
tailing stopped, avoiding duplicate events in the SSE replay buffer.

* feat: add Session.Reactivate to resume tailing from stored offset

Extract a private startTailerLocked helper and a tailerStartMode enum
(modeFromStart, modeFromEnd, modeResume) so StartTailing and Reactivate
share one tailer-launch path under the session write lock.

Reactivate resumes a completed session when a write event arrives after
a flock race in RefreshStates. It picks modeResume when lastOffset>0 so
events already in t... (continued)

Coverage Stats

286 of 315 new or added lines in 5 files covered. (90.79%)

2 existing lines in 1 file now uncovered.

6731 of 8166 relevant lines covered (82.43%)

216.36 hits per line