dangernoodle-io / TaipanMiner / 25033571034

90%

push

github

refactor(stratum): extract response handlers to stratum_machine module (TA-273 Phase 3) (#235)

* refactor(stratum): extract response handlers to stratum_machine module (TA-273 Phase 3)

move mining protocol response parsing out of stratum.c static functions into
pure, host-testable functions in stratum_machine.c/.h. stratum.c wrappers now
delegate to these and own all io, queue dispatch, and logging.

extracted handlers:
- stratum_machine_handle_configure_result — version-rolling mask parse
- stratum_machine_handle_subscribe_result — extranonce1/extranonce2_size parse
- stratum_machine_handle_set_difficulty — bounds-checked difficulty update
- stratum_machine_handle_notify — full mining.notify → stratum_job_t parse
- stratum_machine_build_work — coinbase+merkle+header assembly (pure math)

cJSON ownership rule enforced: handlers receive a bb_json_t they do not own or
retain; caller (process_message) frees. no pointers into the json tree are
stored in state.

adds 18 host tests (306 total): golden cases for each handler, failure paths,
and TA-186 regression guard (non-monotonic job_id sequence updates to most recent).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(stratum): close stratum_machine coverage gap (TA-273 Phase 3)

Added 32 new tests for stratum_machine_build_work and handler NULL guards:
- build_work: happy path, NULL state/output, version_mask, seq increment,
  varying extranonce2 sizes
- builder functions: NULL buffer, zero size guards (15, 37, 58, 78)
- handlers: NULL state, NULL params/result, missing fields, wrong types
  (126, 155, 160, 194)

Coverage: stratum_machine.c now 98% (145/148). Total project 96.9% (96.4%+).

All boards build, static analysis clean, 337 tests pass.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

477 of 578 branches covered (82.53%)

Branch coverage included in aggregate %.

103 of 106 new or added lines in 1 file covered. (97.17%)

1053 of 1087 relevant lines covered (96.87%)

382667.45 hits per line