lsm / neokai / 25016700832
82%

DEFAULT BRANCH: dev
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
25016700832

push

github

web-flow 
fix: guard sub-session MCP servers + replace PendingAgentOverlay (#1670)

* fix(daemon,web): guard sub-session MCP servers from member-sweep overwrite + replace PendingAgentOverlay with ChatContainer

Three related fixes for workflow sub-session issues:

1. **Sub-session MCP server guard** (Issue #2): Add a skip check in
   `SpaceRuntimeService.attachSpaceToolsToMemberSession()` for workflow
   node-agent sub-sessions (identified by session ID pattern
   `*:task:*:exec:*`). The generic member-session `space-agent-tools` server
   lacks the `myAgentName`/`myNodeId` context needed for gate writer
   authorization. After PR #1658 fixed the `session.created` handler,
   this fire-and-forget path could race with the spawn path and silently
   overwrite the sub-session-specific server.

2. **Replace PendingAgentOverlay with ChatContainer** (Issue #3): The
   standalone `PendingAgentOverlay` component had a separate slide-over
   panel with a minimal composer. Now `ChatContainer` accepts a
   `pendingAgent` prop that shows the same "Starting…" state inline.
   When the live session appears via `taskActivity`, it calls
   `replaceOverlayHistory()` to seamlessly transition to the full chat
   view — the overlay stays mounted, no route change needed.
   `AgentOverlayChat` now handles both pending and live modes.
   `PendingAgentOverlay.tsx` and its test file are deleted.

3. **Messaging pipeline analysis** (Issue #1): Traced the full
   coder→reviewer pipeline (8 steps). The daemon-side routing code is
   correct — `AgentMessageRouter`, `ChannelRouter`, `node-agent` tool
   handler, and `injectSubSessionMessage` all properly resolve targets,
   evaluate gates, and deliver messages. The rehydration path
   (`rehydrateSubSession`) correctly rebuilds both `node-agent` and
   `space-agent-tools` MCP servers (fixed in prior Task #126).
   Issue #1's root cause is Issue #2: when MCP servers are lost,
   `send_message` becomes unavailable entirely.

Co-Authored-By: Cl... (continued)
Source Files on build 25016700832
Detailed source file information is not available for this build.