lsm / neokai / 25004392509

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(space): lazy-activate stranded executions and clickable not-started entries (Task #139) (#1663)

* fix(space): re-enable lazy-activation on stranded executions and clickable not-started entries (Task #139)

Closes the two regressions from Task #133's lazy-activation work:

1. Daemon — drop the `executionDeclaredAgentNames` gate on the activation
   kick. Whenever a task agent sends a message to a workflow-declared peer
   that has no live session, queue the message via PendingAgentMessageRepo
   AND fire `ensureWorkflowNodeActivationForAgent`. Mirror in the
   node-agent → node-agent message-router path. Adds the
   `task-agent.send: lazy-activated peer <agentName> for task <taskId>`
   log line. Adds a new `space.task.activateNodeAgent` RPC so the web UI
   can drive the same path on first send from the pending overlay.

2. Web — render workflow-declared "(Not started)" dropdown entries as
   clickable. Clicking opens a new `PendingAgentOverlay` keyed on
   (taskId, agentName) via `pushOverlayHistoryForPendingAgent`. The
   overlay renders a minimal composer; on send it calls
   `spaceStore.activateTaskNodeAgent`, which short-circuits to the live
   session if one exists or queues + kicks activation otherwise. As soon
   as `taskActivity` surfaces a `node_agent` member with the matching
   role, the overlay hands off to the standard `AgentOverlayChat`.

Tests: new daemon unit coverage for the RPC + stranded-execution path,
new web unit coverage for the overlay and the SpaceTaskPane click path.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(space): address review observations for lazy-activation PR

1. Use replaceState instead of pushState for pending→session handoff to
   avoid browser-back ghost state with stale pending:… history entries.
2. Re-enable textarea after first send so users can queue follow-up
   messages while waiting for the session to spawn.
3. Task-status guard was already present (done/cancelled/archived).
4. Au... (continued)

Coverage Stats

9436 of 12636 branches covered (74.68%)

Branch coverage included in aggregate %.

165 of 212 new or added lines in 10 files covered. (77.83%)

1 existing line in 1 file now uncovered.

66988 of 79480 relevant lines covered (84.28%)

303.3 hits per line