lsm / neokai / 24996249054

82%

push

github

fix(space): unify Active-tab filter between sidebar and tasks view (#1662)

* fix(space): unify Active-tab filter between sidebar and tasks view

The sidebar Tasks "Active" sub-tab and the main-pane Tasks view "Active"
tab disagreed about approved tasks. The tasks view (more recently
considered) routes `approved` to Active so a stuck post-approval task
remains visible; the sidebar filter only included `open` and
`in_progress`, so the same task appeared in one surface but not the
other.

Make `isActiveTask` in `task-filters.ts` the single source of truth and
have both consumers import it. Update tests, including a parity check
that walks every status across both consumer code paths.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(space): address review feedback on Active-tab parity

- Replace the tautological parity test (both helpers called the same
  `isActiveTask`) with a real check: export `TAB_PREDICATES` from
  `SpaceTasks.tsx` and assert the tasks-view's `active` predicate
  matches the sidebar's `isActiveTask` for every `SpaceTaskStatus`.
  Test moved to `SpaceTasks.test.tsx` where the necessary signal /
  store mocks are already configured. A future re-inlining of the
  predicate will fail this test loudly.
- Add `approved: 'bg-emerald-500'` to `taskStatusColors` in
  `SpaceDetailPanel.tsx` so the sidebar status dot for `approved`
  tasks matches the emerald accent already used by `SpaceTasks`'s
  `STATUS_BORDER` map.
- Refresh the stale file-header comment in `SpaceTasks.tsx` —
  Active is `open + in_progress + approved`, not just the first two.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

9390 of 12584 branches covered (74.62%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

66818 of 79263 relevant lines covered (84.3%)

304.1 hits per line