stillwater-sc / universal / 24993226829

84%

master: 84%

push

github

feat(lns): scaffolding for configurable add/sub algorithms (Phase A of #777) (#784)

* feat(lns): scaffolding for configurable add/sub algorithms (Phase A of #777)

LNS log-add is a customization-prone operation: hardware targets prefer
table lookup, DSP wants polynomial, hardware codesign wants CORDIC, and
high-precision software wants direct evaluation via constexpr_math
(Epic #763). Hardcoding any one of these into the lns class would force
all consumers to live with that choice.

Phase A introduces the policy-class scaffolding:

- lns_addsub_algorithms.hpp: defines two algorithms behind a uniform
  contract (static add_assign / sub_assign):
  * DoubleTripAddSub -- the historical placeholder (cast to double, do
    native arithmetic, cast back). Default for backward compatibility
    and serves as a correctness oracle.
  * DirectEvaluationAddSub -- exact via cm::log2/cm::exp2 with the
    Gauss log-add formulation; handles same-sign, mixed-sign, zero
    short-circuits, and exact cancellation.
- lns_addsub_traits<Lns>: customization point. Users specialize this
  trait per lns instantiation to opt into a different algorithm.
  Chosen over a 5th template parameter because lns's auto... xtra
  parameter pack must remain last; a traits class is zero-breaking.
- lns_impl.hpp: operator+= and operator-= now delegate to
  lns_addsub_algorithm_t<lns>::add_assign / sub_assign. Default
  selection preserves the prior DoubleTrip behavior exactly.
- log_add_algorithms.cpp: focused regression that cross-validates
  DirectEvaluationAddSub against DoubleTripAddSub over small lns
  configurations and spot-checks DirectEval corner cases (a + (-a),
  zero short-circuits, mixed-sign magnitude subtraction, large
  dynamic range) on a high-precision lns where encoding rounding
  doesn't drown the algorithm signal.

Phases B (Lookup), C (Polynomial / Arnold-Bailey), D (benchmarks +
docs) and E (CORDIC, deferred) are tracked in #780, #781, #782, #783.

Relates to #777

C... (continued)

47 of 47 new or added lines in 2 files covered. (100.0%)

45538 of 53994 relevant lines covered (84.34%)

6357157.87 hits per line