lsm / neokai / 24978072793

82%

push

github

fix(space): forbid Reviewer terminal actions while P0–P3 findings are open (#1655)

* fix(space): forbid Reviewer terminal actions while P0–P3 findings are open

Reviewer agents were calling `submit_for_approval` (and sometimes
`approve_task`) at the end of round 1 even when their own posted review
contained pending P0–P3 findings, prematurely closing the iterative
Coding ↔ Review loop. Both calls are terminal — they hand the task off
to a human or self-close it before the coder has any chance to address
the issues.

Add an explicit "Terminal Action Pre-conditions" block to every
review-style end-node prompt and tighten the `approve_task` /
`submit_for_approval` tool descriptions so the model sees the gating
both at workflow level and at tool-call time. The constraint is hard:
terminal actions are valid ONLY when the verdict is APPROVE with zero
P0–P3 findings AND any prior-round findings have been addressed in the
latest commits reviewed. The wording also explicitly equates
`submit_for_approval` with `approve_task` so the model cannot interpret
it as "let a human decide while findings are open."

Covers:
- Coding Workflow Review node — REQUEST_CHANGES branch now forbids
  both terminal tools, not just approve_task.
- Fullstack QA Loop Review (mid-graph) and QA (end-node) prompts.
- Research Workflow Review node.
- Review-Only Workflow single-node prompt.
- Plan & Decompose Reviewer prompts (4 lenses) and Task Dispatcher.
- ApproveTaskSchema and SubmitForApprovalSchema tool descriptions.

Tests assert the pre-conditions block is present on every affected
prompt and that both terminal tools are forbidden on the REQUEST_CHANGES
branch.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(space): address review feedback on Task #136

- Add Terminal Action Pre-Conditions section to the preset-level
  REVIEWER_CUSTOM_PROMPT in seed-agents.ts so the gating applies to ALL
  Reviewer instances by default, even if a future workflow forgets to
  atta... (continued)

9278 of 12449 branches covered (74.53%)

Branch coverage included in aggregate %.

76 of 76 new or added lines in 2 files covered. (100.0%)

66515 of 78910 relevant lines covered (84.29%)

302.35 hits per line