lsm / neokai / 24976988478

82%

push

github

fix(space): lazy-activate workflow agents on first message (#1654)

* fix(daemon): lazy-activate workflow-declared agents on first message

Task-agent send_message and AgentMessageRouter both treated node_executions
as the source of truth for "is this peer reachable", but workflows lazily
create those rows when each node first activates. A coder messaging the
reviewer before the reviewer node had ticked yielded notFoundAgentNames
instead of queueing the message.

Now both paths consult workflow.nodes (via the existing nodeGroups map for
the router and a new TaskAgentManager.getWorkflowDeclaredAgentNamesForTask
helper for send_message), queue the message via PendingAgentMessageRepository,
and trigger ChannelRouter.activateNode through a new
TaskAgentManager.ensureWorkflowNodeActivationForAgent so the SpaceRuntime
tick loop spawns the session and drains the queue. Hard-error wording is
tightened to distinguish "declared but no session yet" from "unknown agent".

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(web): list every workflow-declared agent in the task pane dropdown

The task-pane "agents" dropdown only listed peers that already had a
session (taskActivity members). Workflow agents waiting on an earlier
node were invisible, even though Task Agent send_message can now lazily
activate them on first contact.

Merge workflow.nodes into the dropdown so every declared peer renders;
agents without a live session show as "(Not started)" and route the
overlay click to the task-agent session as a chat fallback.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(space): address Reviewer feedback on lazy node activation

P1 — Add real unit tests for ensureWorkflowNodeActivationForAgent that
seed a real workflow + workflow_run and stub ChannelRouter.activateNode
so the helper's node-lookup loop and activation call are exercised end
to end (including the negative paths: unknown agent, missing run, and
swallowed activation errors).... (continued)

9278 of 12449 branches covered (74.53%)

Branch coverage included in aggregate %.

102 of 128 new or added lines in 4 files covered. (79.69%)

66462 of 78857 relevant lines covered (84.28%)

298.91 hits per line