lsm / neokai / 24974905597

86%

push

github

feat(desktop): add @neokai/desktop Tauri wrapper bundling daemon as sidecar (#1652)

* feat(desktop): add @neokai/desktop Tauri wrapper bundling daemon as sidecar

Self-contained desktop package at packages/desktop. The Rust shell spawns
the compiled neokai daemon as a Tauri sidecar (port 9283), shows a loading
splash, polls /api/health, then navigates the webview to the daemon's web
UI. build-sidecar.sh reuses scripts/build-binary.ts at the monorepo root,
so the desktop build doesn't introduce a parallel pipeline.

Defaults follow the task's recommended-with-deferral instructions:
productName "Kai", identifier io.neokai.kai, dev port 9283. Updater
plugin is disabled for now (no release pipeline yet) — see PR description
for the open decisions left for human review.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(desktop): address PR review feedback

P1 fixes:
- Remove dead `show_notification` command (never registered, no JS caller)
- Fix Windows bun target name `bun-win-x64` -> `bun-windows-x64`
  (the former is not a valid bun --target) and add it to ALL_TARGETS in
  scripts/build-binary.ts so the cross-build pipeline supports it
- Kill the bundled daemon child before `app.exit(0)` on Quit; exit() calls
  std::process::exit which skips Drop, so without this the daemon can
  outlive the desktop app

P2/P3 fixes:
- Tighten CSP: scope to self + http(s)/ws to localhost:9283 plus the
  inline-style/data-image needs of the splash, instead of `null`
- Replace `window.eval("location.href=...")` with `WebviewWindow::navigate`
  using `tauri::Url`
- Drop redundant DAEMON_PORT const; inline the port literal at the single
  call site
- `exceptionDomain: null` instead of `""` so Tauri does not emit an empty
  NSAppTransportSecurity exception entry
- Trailing newline on Makefile
- Ignore Cargo target/, gen/, binaries/ in biome formatter

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

9259 of 12428 branches covered (74.5%)

Branch coverage included in aggregate %.

66351 of 78719 relevant lines covered (84.29%)

299.29 hits per line