IJHack / QtPass / 24970081225

55%

Build Type

push

github

Committed by web-flow

Commit Message

fix: move processOutputWidget inside centralWidget so it's actually wired up (#1192)

#1172 added the process output panel as a sibling of centralWidget at
the QMainWindow level:

  <widget class="QMainWindow" name="MainWindow">
    <widget class="QWidget" name="centralWidget"> ... </widget>
    <widget class="QWidget" name="processOutputWidget"> ... </widget>  <-- here
    <widget class="QStatusBar" name="statusBar"/>
    <widget class="QToolBar" name="toolBar"> ... </widget>
  </widget>

QMainWindow recognises a fixed set of named slots for its top-level
children — centralWidget, statusBar, menuBar, toolBars and dock widgets.
Anything else parented at that level is created by uic but never placed
in the QMainWindow's layout, so it gets ignored by the QMainWindowLayout
and renders on top of (i.e. obscures) the centralWidget content.

The visible symptom is that with HEAD, the QtPass main window comes up
with the toolbar at top and the status bar at the bottom but a *blank*
centre — no profile selector, no search box, no tree view, no text
browser. Bisected against pre-#1172 (`8e257d633`) where the same
.ui structure (modulo this addition) renders correctly.

Move processOutputWidget to row=2/colspan=2 inside centralWidget's
QGridLayout (where it's a real layout participant) and let it stretch
across the bottom of the central area. The runtime call to
`statusBar()->addPermanentWidget(ui->processOutputWidget)` from
initStatusBar() then re-parents it to the status bar; at that point
QMainWindow's layout reclaims the row 2 space for the actual content
above it.

Verified by screenshot: search box, tree view, profile selector and
welcome browser all reappear; status bar with the lock icon still
shows; no test regressions (12/12 suites green); doxygen clean.

Coverage Stats

0 of 34 new or added lines in 1 file covered. (0.0%)

65 existing lines in 2 files now uncovered.

1825 of 6614 relevant lines covered (27.59%)

26.92 hits per line