24962433832
55%

Ran 26 Apr 2026 05:21PM UTC

Jobs 1

Files 72

Run time 1min

Badge

Embed ▾

Committed 26 Apr 2026 05:16PM UTC coverage: 27.622%. Remained the same

Build # 24962433832

Build Type

push

github

Committed by

web-flow

Commit Message

fix: don't schedule initial focus pulse before init() completes (#1187)

Reproduced via SIGSEGV on a fresh-config launch:

  #0  QLineEdit::selectAll()
  #1  MainWindow::focusInput()
  #2  ... (timer event)
  #3  QEventLoop::exec()       ← nested loop from QDialog::exec()
  #4  ConfigDialog::wizard()
  #5  MainWindow::config()
  #6  QtPass::init()
  #7  MainWindow::MainWindow()

`MainWindow`'s constructor was scheduling
`QTimer::singleShot(10, this, SLOT(focusInput()))` *before* calling
`m_qtPass->init()`. On a fresh install (no `.gpg-id`/invalid config),
`init()` calls `MainWindow::config()` which runs the first-run wizard
via `QDialog::exec()` — i.e. a nested event loop. The 10 ms timer
fires inside that loop while the main window has not yet been shown,
`focusInput()` runs, and `QLineEdit::selectAll()` crashes inside Qt
because the line-edit's owning top-level isn't visible/realized yet.

Move the timer scheduling to *after* `init()` returns successfully,
and bail out of the constructor early when init fails. The success
path is unchanged for normal launches; the wizard path no longer
queues the focus pulse during the nested loop, and the failure path
no longer queues it before destruction.

Coverage Stats

1825 of 6607 relevant lines covered (27.62%)

26.95 hits per line

Coverage Regressions

Lines	Coverage	∆	File
2	0.0	0.0%	src/mainwindow.cpp

Jobs

ID	Job ID	Ran	Files	Coverage
1	24962433832.1	26 Apr 2026 05:21PM UTC	72	27.62	GitHub Action Run

IJHack / QtPass / 24962433832
55%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 24962433832

IJHack / QtPass / 24962433832 55%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 24962433832

IJHack / QtPass / 24962433832
55%

README BADGES
x