lsm / neokai / 24961785619

82%

push

github

fix(daemon): rehydrate sub-session MCP servers across daemon restart (#1646)

* fix(daemon): rehydrate sub-session MCP servers across daemon restart

Task #126: after a daemon restart, coder/reviewer sub-sessions sitting
at a code-ready-gate silently lost their `node-agent` and
`space-agent-tools` MCP servers, so any `write_gate` / `read_gate` /
`send_message` call died with "No such tool available". Two gaps caused
this:

1. `SpaceTaskRepository.listActiveWithTaskAgentSession` excluded `'review'`
   status, so the parent task agent was never rehydrated while the workflow
   waited at the review gate.
2. `TaskAgentManager.rehydrateTaskAgent` did not eagerly rehydrate
   workflow sub-sessions, so they only came back via the lazy
   `injectSubSessionMessage` path. UI/RPC paths that resolve a sub-session
   through `SessionManager.getSessionAsync` short-circuit on
   `AgentSession.restore()` and never reach `rehydrateSubSession`, leaving
   the session with no in-process MCP servers attached.

This commit:
- Adds `'review'` to the active-status set in
  `listActiveWithTaskAgentSession` and documents the per-status rationale.
- Adds a private `rehydrateSubSessionsForRun` helper invoked at the end
  of `rehydrateTaskAgent` to eagerly rehydrate every sub-session whose
  `NodeExecution` still carries an `agentSessionId`. Failures are isolated
  per sub-session.
- Updates docstrings on `rehydrate` / `rehydrateTaskAgent` to describe
  the new behaviour and removes the prior misleading note about
  "subSessions map rebuilt from sub-session tasks" (no such code existed).
- Adds focused tests in `task-agent-manager-rehydration.test.ts` covering
  the eager rehydration path for `in_progress` and `'review'` statuses,
  multi-sub-session runs, executions with no `agentSessionId`, and the
  repository-level inclusion of `'review'`.
- Updates `space-task-repository.test.ts` to assert `'review'` is now in
  the active set and is no longer in the exclusion set.

Co-Auth... (continued)

9244 of 12413 branches covered (74.47%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 2 files covered. (100.0%)

66450 of 78821 relevant lines covered (84.3%)

298.99 hits per line