IJHack / QtPass / 24956139804
55%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 72
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 27.622% (+0.1%) from 27.527%
24956139804

push

github

web-flow 
chore: post-merge cleanups across tests and SettingsConstants (#1184)

Sweep of small findings flagged after the #1162/#1170/#1171/#1172
merges:

- Make SettingsConstants() = delete. The class is a namespace of
  static const QStrings; the existing default constructor served no
  purpose and just invited accidental instantiation. Remove the
  =default in the .cpp and replace the explicit declaration with
  =delete in the header.
- Sweep every `tests/auto/*/*.pro` to use `QMAKE_LINK_OBJECT_MAX = 24`
  with surrounding spaces, matching the assignment style used
  throughout `qtpass.pri` (e.g. VERSION = 1.7.0, QMAKE_LFLAGS += …).
  Done across all 10 test pro files at once so we don't introduce a
  new inconsistency by fixing only one.
- tst_exportpublickeydialog.cpp / tst_importkeydialog.cpp: replace
  the manual two-call clipboard-restore pattern with a QScopeGuard so
  the user's clipboard is reset on every exit path (early QSKIP,
  normal completion, or QVERIFY/QCOMPARE failure). Also swap the
  fragile `QMetaObject::invokeMethod(&dialog, "on_<name>_clicked",
  Qt::DirectConnection)` calls for `findChild<QPushButton*>` +
  `click()` — type-safe, and exercises the same auto-connected slot
  via the actual button signal.

Build/Doxygen/clang-format clean; all 12 test suites green
(106+46+19+107+7+21+8+16+15+33+21/1+19).

The HEADERS += <production_header> reference flagged in
importkeydialog.pro is left in place: same pattern is established
across model.pro, filecontent.pro, gpgkeystate.pro, util.pro,
ui.pro, simpletransaction.pro. Removing it from one file alone would
introduce inconsistency; a sweep is its own PR.

1825 of 6607 relevant lines covered (27.62%)

26.95 hits per line

Coverage Regressions

Lines Coverage ∆ File
9
0.0
 0.0% src/qrc_qmake_qmake_qm_files.cpp
2
51.9
 -0.42% src/imitatepass.cpp
Jobs
ID Job ID Ran Files Coverage
1 24956139804.1 72
27.62
 GitHub Action Run
Source Files on build 24956139804