umputun / revdiff / 24939315550

90%

push

github

feat(ui): vertical scrollbar thumb on diff pane right border (#151)

* feat(ui): show scroll-position thumb on diff pane right border

Replace the right-border │ with a heavy ┃ on rows that map to the
visible viewport portion, giving an at-a-glance indicator of scroll
position and content length. Implemented as a post-process pass on the
lipgloss-rendered pane (same pattern as padContentBg/extendLineBg/
applyHorizontalScroll), so the surrounding ANSI envelope — including
focused-vs-inactive border color and BorderBackground — is preserved.

Thumb is bold-wrapped via \x1b[1m...\x1b[22m to brighten the accent
color without resetting the border background. No-op when content fits
the viewport. Diff pane only; tree pane untouched.

* fix(review-loop): iteration 1 addressed 17 findings

- [critical] [app/ui/view.go,scrollbar.go] truncate diff header so long filenames
  don't soft-wrap and push viewport rows past scrollbarFirstViewportRow=2
- [doc] [app/ui/scrollbar.go:22] godoc said "half-block thumb glyph" — rune is
  heavy-vertical; updated wording
- [doc] [app/ui/scrollbar.go:23] godoc no-op clause now mentions vh<=0 case
- [doc] [app/ui/scrollbar.go:5-22] document intentional bold-only --no-colors
  behavior + scrollbarFirstViewportRow coupling warning
- [doc] [CLAUDE.md] clarify post-pane vs per-line transform; document
  single-line header invariant via truncateHeaderTitle
- [doc] [docs/ARCHITECTURE.md] add scrollbar.go to app/ui per-file table
- [minor] [app/ui/scrollbar.go:38-41] drop unreachable maxStart>0 guard
- [minor] [app/ui/scrollbar_test.go:217] fix comment "5 lines total" → 6
- [test] [app/ui/scrollbar_test.go] add TestApplyScrollbar_ThumbWrappedInBoldSGR
  to lock in the bold SGR contract
- [test] [app/ui/scrollbar_test.go] add TestApplyScrollbar_RowWithoutTrackRune
  to cover the idx<0 branch
- [test] [app/ui/scrollbar_test.go] add TestApplyScrollbar_BodyContainingTrackRune
  to cover content rows containing literal │
- [test] [app/ui/sc... (continued)

120 of 121 new or added lines in 2 files covered. (99.17%)

8527 of 9524 relevant lines covered (89.53%)

549.16 hits per line