umputun / revdiff / 24939101884

90%

master: 90%

Pull #151

github

fix(review-loop): iteration 3 addressed 10 findings

- [critical] [app/ui/view.go] apply sanitizeFilenameForDisplay to status-bar
  filename segments (statusBarText, statusSegmentsNoSearch,
  statusSegmentsMinimal). previously the sanitizer was scoped to the diff
  header only — a crafted filename with newline/ESC could still break or
  spoof the bottom-of-screen layout
- [major] [app/ui/view.go] extend sanitizeFilenameForDisplay to strip
  Unicode bidi/format controls (RTL/LTR overrides U+202A–U+202E, isolates
  U+2066–U+2069, ZWJ/ZWNJ/ZWSP U+200B–U+200D, BOM U+FEFF) — defense in
  depth against filename spoofing
- [code-quality] [app/ui/view.go] convert sanitizeFilenameForDisplay and
  truncateLeftToWidth from package-level functions to Model methods, per
  project rule preferring methods over standalone helpers
- [code-quality] [app/ui/view.go] pass diffPaneW into renderTwoPaneLayout
  instead of re-deriving the formula inline — single source of truth so a
  future change to one side cannot drift from the other
- [code-quality] [app/ui/view.go] simplify truncateHeaderTitle: paneW<=1
  now delegates to truncateLeftToWidth instead of mirroring its boundary
  cases inline
- [test] [app/ui/scrollbar_test.go] strengthen
  TestApplyScrollbar_SafeWhenLinesShorterThanExpected with Equal+NotContains
  assertions (was only asserting line count preserved, would have passed
  with a thumb mistakenly applied)
- [test] [app/ui/scrollbar_test.go] add bidi/format char cases to
  TestSanitizeFilenameForDisplay (RTL override, LRI, PDI, ZWJ, ZWSP, BOM)
- [test] [app/ui/view_test.go] add TestModel_StatusBarSanitizesFilename
  regression covering newline/CR/tab/ESC/RTL/BOM in the status bar

120 of 121 new or added lines in 2 files covered. (99.17%)

8527 of 9524 relevant lines covered (89.53%)

549.16 hits per line