chrisns / repomanager / 24936046787

85%

push

github

Stop ruleset planner looping on GitHub server-side defaults

GitHub stores the pull_request rule with extra fields the API never
asked us to send — required_reviewers: [], allowed_merge_methods —
which made rulesetEquals' JSON.stringify comparison flip to "different"
forever. Every cron tick planned an update, the cron reopened the
consent issue with a ruleset:update item, the user saw a fresh row to
tick on a previously-resolved issue, and applying the update just
re-stored the same defaults.

rulesetEquals now uses subset semantics on rule parameters (existing
must contain every key/value the desired declares; extras are fine)
and explicitly compares bypass_actors (so changes there do trigger an
update). Rule count must still match exactly so a removal plans an
update too.

269 of 345 branches covered (77.97%)

Branch coverage included in aggregate %.

24 of 27 new or added lines in 1 file covered. (88.89%)

502 of 538 relevant lines covered (93.31%)

13.52 hits per line