Freegle / Iznik / 5849

72%

master: 70%

Build Type

Pull #251

circleci

Committed by edwh

Commit Message

test(coverage): chat notification filtering + location_test unused var fix TDD coverage

Add 9 integration tests verifying PR #245 fix (don't notify users who have
closed or blocked a chat):

- TestClosedChatHiddenFromUserChatList: status=Closed removes chat from /api/chat
- TestBlockedChatHiddenFromUserChatList: status=Blocked removes chat from /api/chat
- TestClosedChatVisibleWithIncludeClosed: includeClosed=true overrides filter
- TestOnlySenderClosedChatRecipientStillSees: filter is per-viewer (c1.userid=myid)
- TestBothUsersClosedNeitherSeeChat: both close → neither sees the chat
- TestNullRosterStatusShowsChat: null/absent roster entry shows chat normally
- TestUser2ModClosedByMemberHiddenFromMember: member closing User2Mod chat hides it from member; mod still sees via ModTools
- TestMTUnseenCountExcludesClosedModChat: getModeratorChatIDs() filters status!=Closed
- TestClosedChatUnseenIsHiddenNotZeroed: documents that notifications are prevented by hiding the chat, not zeroing unseen count

Also fix pre-existing build failure in location_test.go (unused variable
initialPolygon declared but never read).

1936 Go tests pass.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Pull Request Pull Request #251: test(coverage): chat notification filtering TDD coverage

Coverage Stats

13316 of 20228 branches covered (65.83%)

Branch coverage included in aggregate %.

23 of 29 new or added lines in 2 files covered. (79.31%)

32 existing lines in 5 files now uncovered.

96347 of 132901 relevant lines covered (72.5%)

21.65 hits per line