Freegle / Iznik / 5841

72%

master: 70%

Build Type

Pull #249

circleci

Committed by edwh

Commit Message

fix(ci): revert PW_WORKERS and test-skipping logic causing Playwright failures

Root cause analysis (job #5815):
1. **PW_WORKERS 1→4 caused resource contention**: Increased parallelism from 1 to 4 on the CI cloud machine triggered 'Failed to fetch' errors in Playwright tests. Browser console logs show TypeError: Failed to fetch when fetching from API, indicating the server couldn't handle the concurrent load or network timeouts increased.
2. **Test-skipping logic caused false test coverage**: Changed from 'always run all suites' to selective skipping based on changed files. This would cause feature branch PRs to skip test suites (e.g., Playwright for Go-only changes), breaking Coveralls carryforward and showing false coverage decreases.

Fixes:
- Revert PW_WORKERS to 1 for cloud machines (safe value proven in production)
- Revert to always running all test suites on every branch (prevents Coveralls false positives)
- Self-hosted runner keeps its dedicated PW_WORKERS setting (if any)

The PR's actual code changes (fatal error handler in queue:background-tasks) remain unchanged and are unrelated to the test failures.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Pull Request Pull Request #249: fix(batch): report PHP fatal errors (incl. OOM) to Sentry on shutdown

Coverage Stats

13356 of 20230 branches covered (66.02%)

Branch coverage included in aggregate %.

17 of 22 new or added lines in 1 file covered. (77.27%)

20 existing lines in 5 files now uncovered.

96359 of 132901 relevant lines covered (72.5%)

21.7 hits per line