Freegle / Iznik / 5828

70%

push

circleci

fix(tests): stop logoutIfLoggedIn from hanging on 'Something went wrong' page

Root cause: under CI load (6 parallel workers) the Go API sometimes fails
during SSR, causing the homepage to render "Something went wrong". The old
code used gotoAndVerify() for the post-logout navigation, which detected
this and took screenshots (no timeout) before re-throwing — this could eat
hundreds of seconds per call. With two gotoAndVerify calls (try + catch)
and the test's own overhead, the total easily hit the 600-second test
timeout.

Fix: replace both gotoAndVerify() calls in logoutIfLoggedIn() with direct
page.goto() calls that silently ignore navigation/content errors. The
only purpose of navigating to '/' after logout is to reset page state for
the next test step — content errors are irrelevant at that point.

Also add diagnostic logging throughout:
- gotoAndVerify now logs which step failed (page.goto / loading-indicator /
  body-visible / content-check) and caps all screenshot calls at 15 seconds
- logoutIfLoggedIn logs entry URL, try-block failures, and labels try vs
  catch block navigation
- test-reply-flow-social logs [4.1] Step N: timestamps so test progress is
  identifiable even in interleaved 6-worker CI logs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

8898 of 10275 branches covered (86.6%)

Branch coverage included in aggregate %.

95559 of 143692 relevant lines covered (66.5%)

18.7 hits per line