IJHack / QtPass / 24886838532

55%

Build Type

push

github

Committed by web-flow

Commit Message

fix: address Copilot review findings (#1150)

* fix: address Copilot review findings

mainwindow.cpp/.h:
- Null-check keygenDialog before close() in cleanKeygenDialog()
- Return early in initTrayIcon() if allocation reports null
- Replace placeholder comment on wizard() call
- Rename member keygen → keygenDialog to match getKeygenDialog()

passworddialog.h/.cpp:
- Default-initialise m_isNew to match m_templating style
- Rename templateLines/otherLines to m_templateLines/m_otherLines
  per project naming convention

util.cpp:
- Add direct include for executor.h (was only available transitively
  via qtpasssettings.h → realpass.h → pass.h)

tst_settings.cpp:
- Rename portable_ini → portableIni (camelCase consistency)

Rejected findings (would have regressed behaviour):
- isUseGit auto-detection assertion suggested by Copilot would fail
  against the real implementation, which only auto-detects when
  defaultValue is true and storedValue equals the default
- Renaming setAndGetDialogSize → setAndGetDialogSizeWithKey would
  diverge from sibling tests (setAndGetDialogPos / DialogMaximized
  / DialogGeometry) that all take a key without the suffix

* fix: apply CodeRabbit auto-fixes

Fixed 3 file(s) based on 2 unresolved review comments.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

* fix: apply CodeRabbit auto-fixes

Fixed 1 file(s) based on 1 unresolved review comment.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

* fix: apply CodeRabbit auto-fixes

Fixed 1 file(s) based on 1 unresolved review comment.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

Coverage Stats

12 of 20 new or added lines in 3 files covered. (60.0%)

1 existing line in 1 file now uncovered.

1640 of 6113 relevant lines covered (26.83%)

28.94 hits per line