dangernoodle-io / breadboard / 24869163356

100%

push

github

fix(ota_pull): log "completed" before calling resume hook (#76)

The ota_check_worker_task used to call s_resume_cb before the
"background check completed" log, which made serial output look like:

  mining: mining paused for maintenance
  bb_ota_pull: update available: ...
  mining: mining resumed
  bb_ota_pull: background check completed

Operators consistently read that sequence as "the check hasn't finished
yet — why is mining resuming?" The resume call is correct (the network
work is done) but the ordering confused the story.

Move the resume call to after the critical-section state update and the
"completed" log so the sequence reads in the order expected:

  mining: mining paused for maintenance
  bb_ota_pull: update available: ...
  bb_ota_pull: background check completed
  mining: mining resumed

Mining stays paused a few microseconds longer across the critical
section — trivial against the multi-second network fetch the pause was
already covering.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

81 of 81 branches covered (100.0%)

Branch coverage included in aggregate %.

113 of 113 relevant lines covered (100.0%)

274.59 hits per line