lsm / neokai / 24869029861

83%

push

github

fix(web): gate chat empty state on first messages snapshot (#1614)

Chat UI briefly rendered the "No messages yet" empty state on slow
networks and during task/group switches because loading was tracked
only on session metadata (`state.session` RPC), not on the independent
`messages.bySession` LiveQuery snapshot. Once metadata landed, the UI
flipped out of the loading state even though rows were still empty.

Fix by introducing a separate gate for messages:

- `SessionStore` now exposes `messagesLoaded` (signal). It resets to
  false on session switch and flips true when the first snapshot is
  applied (or the subscribe rejects, to avoid stalling forever).
- `ChatContainer` gates `isInitialLoad` and `loading` on both
  `sessionState !== null` AND `messagesLoaded`, so the empty state is
  never shown while a snapshot is in flight.
- `useSpaceTaskMessages` / `useGroupMessages` replace their
  `isLoading` useState with derived state (`loadedForId !== currentId`)
  so the very first render — before effects fire — already reports
  `isLoading=true`, and task/group switches flip it back to `true`
  synchronously without a render-cycle flash.

Includes regression tests for all three code paths.

9045 of 12284 branches covered (73.63%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 3 files covered. (100.0%)

68369 of 77209 relevant lines covered (88.55%)

298.77 hits per line