bitcoindevkit / bdk / 24847417053

79%

master: 78%

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk#2174: fix(chain): prevent `merge_chains` from replacing the genesis block

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/be8e156115e21750158d44394341f1d41dfbf90f">be8e15611 fix(chain): prevent `merge_chains` from replacing the genesis block (Elias Rohrer)

Pull request description:

  ### Description

  Other code paths (`disconnect_from`, `CheckPoint::insert`) already protect height 0 from modification, but `merge_chains` allowed an update chain with a different genesis hash to silently replace the wallet's existing genesis block. Return `CannotConnectError` when the update attempts to change the block hash at height 0.

  Co-Authored-By: HAL 9000

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK be8e156115e21750158d44394341f1d41dfbf90f
  evanlinjin:
    ACK be8e156115e21750158d44394341f1d41dfbf90f

Tree-SHA512: 743c95f28a6186721a5241fc9a873cbb4a6

Coverage Stats

386 of 524 branches covered (73.66%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

4401 of 5510 relevant lines covered (79.87%)

2302.88 hits per line