bitcoindevkit / bdk / 24522573978

79%

master: 78%

push

github

Merge bitcoindevkit/bdk#2170: fix(chain): add missing `continue` in `CanonicalIter` assumed-tx processing

<a class=hub.com/bitcoindevkit/bdk/commit/27ab7ee0f212d9853fcff693f3bc22f9c6956105">27ab7ee0f<a href="https://github.com/bitcoindevkit/bdk/commit/f07423a7bab932035113bd14c4ad82017dcd4096"> fix(chain): add missing `continue` in `CanonicalIter` assumed-tx processing (Elias Rohrer)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/c4c87c51a3ea5262ea195cc895ecb0ae3235f739">c4c87c51a</a> ci: pin `hyper-rustls` to 0.27.7 for 1.75.0 toolchain (valued mammal)

Pull request description:

  ### Description
  Without the `continue`, the loop falls through to the subsequent processing blocks when assumed-canonical transactions are the only remaining unprocessed source. If the anchored, seen, and leftover iterators are all exhausted, the loop reaches `return None` and silently drops the assumed transactions that were just marked canonical.

  ### Notes to the reviewers

  Co-Authored-By: HAL 9000

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 27ab7ee0f212d9853fcff693f3bc22f9c6956105

Tree-SHA512: 9d06d6b2524925e2094c1d04f536a582a14

385 of 522 branches covered (73.75%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4397 of 5505 relevant lines covered (79.87%)

2131.71 hits per line